Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Localization bugs in Wallet #880

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Conversation

faizhashmiRnS
Copy link
Contributor

Description

Following issues are resolved in this PR:

  1. Pylons Wallet Language Settings Errors  #871

@faddat faddat enabled auto-merge August 25, 2022 14:18
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise it looks good.

"create_new_wallet": "Erstellen Sie eine neue Brieftasche",
"proceed": "Fortfahren",
"security_hint": "Befolgen Sie Best Practices für die Sicherheit. Achten Sie darauf, Ihre mnemonische Passphrase an einem sicheren Ort aufzuschreiben. Dieser Satz ist die einzige Möglichkeit, Ihr Konto wiederherzustellen, wenn Sie Ihr Passwort vergessen haben. Ohne Ihr Passwort oder Ihre Wiederherstellungs-Passphrase ist eine Kontowiederherstellung nicht möglich. Auch Emeris kann dir nicht helfen.",
"import_an_account": "Importieren Sie ein Konto",
"create_wallet": "Brieftasche erstellen",
"terms_of_service": "Nutzungsbedingungen",
"manage_your_nft": "VERWALTEN SIE IHR NFT",
"pylons_infrastructure": "Pylons ist eine schnelle NFT-Infrastruktur",
"pylons_infrastructure": "Pylons ist eine schnelle NFT Infrastruktur",
"sell_and_buy_artworks": "KUNSTWERKE VERKAUFEN UND KAUFEN",
"transactions_free": "Transaktionen sind kostenlos",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we trying to say "Free Transactions" or "Transactions are free?". If it's transactions are free, translation is correct. Otherwise we need to fix it.

@faddat faddat merged commit 1fd61a1 into main Aug 25, 2022
@faddat faddat deleted the fix/localization_design_issues branch August 25, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants