Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dynamic SKU #866

Merged
merged 7 commits into from
Aug 24, 2022
Merged

Feat/dynamic SKU #866

merged 7 commits into from
Aug 24, 2022

Conversation

kjawadDeveloper2
Copy link
Collaborator

Added the logic for the dynamic SKU. The skus will come from the firebase dynamic link.
Solved firebase dynamic link internal error.
Solved the issue with the mongo url .

@faddat faddat enabled auto-merge August 24, 2022 16:44
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, otherwise code is good for @faisalnaveedRNS to take over after the approval.

];

///review your nft

const String kPylonsFeeMsg =
"The Pylons fee is the network fee assessed on all transactions equal to 10% of the listed price.";
const String kPylonsFeeMsg = "The Pylons fee is the network fee assessed on all transactions equal to 10% of the listed price.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all transactions which is equal to 10% of the listed price"

Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@faddat faddat merged commit 7353968 into main Aug 24, 2022
@faddat faddat deleted the feat/dynamic_sku branch August 24, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants