Fix/nftpurchase url #704
Merged
Fix/nftpurchase url #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSofaer
reviewed
Aug 1, 2022
| @@ -222,6 +224,11 @@ export default class EaselBuy extends Component { | |||
| window.location = `${baseURL}ofl=${ofl}&link=${encodeURIComponent( | |||
| window.location.href | |||
| )}`; | |||
|
|
|||
There was a problem hiding this comment.
used to generate deep link generation.
MikeSofaer
reviewed
Aug 1, 2022
| @@ -451,6 +460,9 @@ export default class EaselBuy extends Component { | |||
| <div className="item"> | |||
| <p>Creation Date</p> | |||
| <p> | |||
| {console.log(createdAt,moment | |||
|
Lots of console logs in here. We should maybe have a logging system. |
abdullahjankhan1
requested review from
faddat and
faisalnaveedRNS
as code owners
faddat
approved these changes
Aug 1, 2022
|
Is this ready to merge? Still marked draft |
MikeSofaer
approved these changes
Aug 2, 2022
faisalnaveedRNS
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #PS-226
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change