Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test/msg server complete execution early test #672

Merged
merged 7 commits into from
Jul 20, 2022
Merged

Update test/msg server complete execution early test #672

merged 7 commits into from
Jul 20, 2022

Conversation

ThanhNhann
Copy link
Contributor

What is the purpose of the change

  • Add table-driven test for msg_server_complete_execution_early_test.go

Brief Changelog

  • Add more test cases and add table-driven tests for test cases

Testing and Verifying

  • This change is a trivial rework/code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduces a new feature or user-facing behaviour changes? no
  • How is the feature or change documented? not applicable

Notional-labs

faddat
faddat approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this is going to be fun. Sorry haven't had the chance to meet you yet!

@faddat
fix
bbe4727
@faddat
Merge remote-tracking branch 'upstream/faddat/golangci-timeout' into …
621e093 
…update-test/msg_server_complete_execution_early_test
@faddat faddat merged commit 2fcc4bd into Pylons-tech:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat approved these changes

@faisalnaveedRNS faisalnaveedRNS faisalnaveedRNS approved these changes

@mustafapylons mustafapylons Awaiting requested review from mustafapylons

@MikeSofaer MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThanhNhann @faddat @faisalnaveedRNS