-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/events #573
Fix/events #573
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple copy/pastes to fix and CI/CD has to pass.
repeated Item mintItems = 8 [(gogoproto.nullable) = false]; | ||
repeated Item modifyItems = 9 [(gogoproto.nullable) = false]; | ||
repeated cosmos.base.v1beta1.Coin burnCoins = 3 [ | ||
(gogoproto.nullable) = false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line has been copy/pasted a lot throughout the code, more reusability would be better.
repeated Item modifyItems = 9 [(gogoproto.nullable) = false]; | ||
repeated cosmos.base.v1beta1.Coin burnCoins = 3 [ | ||
(gogoproto.nullable) = false, | ||
(gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same with this line as well, too many copy/pastes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automatically generated code, code looks good to me now.
Description
Closes: #PS-293
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change