fix/same user minter #568
Merged
fix/same user minter #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdullahjankhan1
requested review from
mustafapylons and
MikeSofaer
as code owners
MikeSofaer
approved these changes
May 23, 2022
| @@ -27,6 +27,24 @@ func TestSetItemString(t *testing.T) { | |||
| executedItemID := "testItemID" | |||
| itemMutableStringField := "itemMutableStringField" | |||
| itemMutableStringValue := "itemMutableStringValue" | |||
| accs := GenerateAddressesInKeyring(val.ClientCtx.Keyring, 2) | |||
There was a problem hiding this comment.
"2" in this statement and following repetitions can be replaced with constant variable.
| @@ -27,6 +27,24 @@ func TestSetItemString(t *testing.T) { | |||
| executedItemID := "testItemID" | |||
| itemMutableStringField := "itemMutableStringField" | |||
| itemMutableStringValue := "itemMutableStringValue" | |||
| accs := GenerateAddressesInKeyring(val.ClientCtx.Keyring, 2) | |||
| common := []string{ | |||
| fmt.Sprintf("--%s=%s", flags.FlagFrom, accs[0].String()), | |||
There was a problem hiding this comment.
accs[0] has been repeated throughout the code and position "0" can be replaced with constant as well.
x/pylons/client/cli/tx_trade_test.go
Outdated
| common := []string{ | ||
| fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()), | ||
| common = []string{ | ||
| fmt.Sprintf("--%s=%s", flags.FlagFrom, accs[0].String()), | ||
| fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation), |
There was a problem hiding this comment.
multiple code blocks have been copy pasted, code reuse can be emphasized.
mustafapylons
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creator of recipe cannot mint the recipe.
Closes: https://pylonstech.atlassian.net/browse/PS-334
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change