Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added File extension on Chain (Easel & Wallet) #1532

Merged
merged 5 commits into from
Dec 10, 2022
Merged

Added File extension on Chain (Easel & Wallet) #1532

merged 5 commits into from
Dec 10, 2022

Conversation

ahmadhassan-dev1
Copy link
Contributor

Issue mentioned in: #1462

@ahmadhassan-dev1
Copy link
Contributor Author

image

@Tanyaml
Copy link

Tanyaml commented Dec 7, 2022

@Amean @afti-githobo Please review.

@heyitsjk
Copy link

heyitsjk commented Dec 7, 2022 •
edited
Loading

unnamed-15

@ahmadrns what is the Easel icon? Shouldn't this be the download icon? @StefanB90
also, the Views icon needs to be above the Like icon.

Figma Design:
Full screen NFT view (pop-up maximized) (1)

@ahmadhassan-dev1
Copy link
Contributor Author

@heyitsjk I just get the latest code from main and add the extension functionality about the issue and make PR. I will look into the design changes too and refactor code accordingly.

@ahmadhassan-dev1
Copy link
Contributor Author

@heyitsjk This icon is for setting wallpaper in case of image NFT

@ahmadhassan-dev1
Copy link
Contributor Author

@heyitsjk As discussed with @Kamran-Khan-Gene download feature is implemented but not merge yet as it has some blockers so can I remove wallpaper icon and add views Icons on top of like icon?.

@heyitsjk
Copy link

heyitsjk commented Dec 8, 2022

@ahmadrns ah that makes sense, if the wallpaper feature is ready to go then that could sit there for now until we're ready to add download and move the icons around. @StefanB90

wallpaper feature is Android-only, correct? Since iOS can not set user device wallpaper natively

@ahmadhassan-dev1
Copy link
Contributor Author

@heyitsjk Okay for now leaving it as it is and when we need to add Download feature then we will arrange icons and also remove this wallpaper icon too
Yes, this is for Android only.

@MikeSofaer MikeSofaer merged commit 26685e8 into main Dec 10, 2022
@MikeSofaer MikeSofaer deleted the feat/add_file_extension branch December 10, 2022 20:24
@zube zube bot removed the [zube]: Done label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amean Amean Amean approved these changes

@kjawadDeveloper2 kjawadDeveloper2 kjawadDeveloper2 approved these changes

@faddat faddat Awaiting requested review from faddat

@MikeSofaer MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

@faisalnaveedRNS faisalnaveedRNS Awaiting requested review from faisalnaveedRNS faisalnaveedRNS is a code owner

@afti-githobo afti-githobo Awaiting requested review from afti-githobo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ahmadhassan-dev1 @Tanyaml @heyitsjk @Amean @kjawadDeveloper2 @MikeSofaer