Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(testapp) Structure sword stuff better in the ui + warn when battles will 100% kill you. #1512

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

afti-githobo
Copy link
Contributor

Description

This pull request implements requested revisions to the testapp UX:

  • You have skull icons on battles you'll always lose.
  • The buy/upgrade sword buttons only appear if you're currently working toward sword level 1 or 2, respectively, and are greyed out and unusable if you don't have enough of the respective currencies.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MikeSofaer MikeSofaer merged commit 5d6016a into main Dec 2, 2022
@MikeSofaer MikeSofaer deleted the ui_refinements branch December 2, 2022 17:32
@zube zube bot removed the [zube]: Done label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants