Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases was added for AfterEpochEnd function #1429

Merged
merged 22 commits into from
Dec 16, 2022
Merged

Conversation

AbdulSamad876
Copy link

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Tanyaml
Copy link

Tanyaml commented Nov 23, 2022

Not QA testable.

@faisalnaveedRNS faisalnaveedRNS marked this pull request as ready for review November 24, 2022 05:28
Copy link
Collaborator

@MikeSofaer MikeSofaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this show that delegators are not being paid?

@faisalnaveedRNS
Copy link
Collaborator

  1. artist distribution
  2. validator distribution
  3. bedrock holder distribution (deligators)

@faisalnaveedRNS
Copy link
Collaborator

Test cases should cover specially token encomics

@abdullahjankhan1 abdullahjankhan1 marked this pull request as draft November 29, 2022 06:30
@abdullahjankhan1 abdullahjankhan1 marked this pull request as ready for review November 29, 2022 12:57
@StefanB90
Copy link

Refactor test case to make it more readable. Focus on executable test.

Copy link
Collaborator

@MikeSofaer MikeSofaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is relying on the CalculateDelegatorsRewards to create the list of people who should be paid out, I would like it to instead get the list of Bedrock holders and validators from the chain and use that to iterate. The current method is checking against itself a little too much.

@Tanyaml
Copy link

Tanyaml commented Dec 7, 2022

Show that validators are getting paid and see how the the tokens work as intended and test on mutilsig. @faisalnaveedRNS

@MikeSofaer MikeSofaer merged commit fc683fb into main Dec 16, 2022
@MikeSofaer MikeSofaer deleted the Issue/764-TestCases branch December 16, 2022 14:52
@zube zube bot removed the [zube]: Done label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants