-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases was added for AfterEpochEnd function #1429
Conversation
Not QA testable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this show that delegators are not being paid?
8f406c1
to
9733aec
Compare
…nto Issue/764-TestCases
|
Test cases should cover specially token encomics |
…nto Issue/764-TestCases
Refactor test case to make it more readable. Focus on executable test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is relying on the CalculateDelegatorsRewards to create the list of people who should be paid out, I would like it to instead get the list of Bedrock holders and validators from the chain and use that to iterate. The current method is checking against itself a little too much.
84989dd
to
dd263cb
Compare
Show that validators are getting paid and see how the the tokens work as intended and test on mutilsig. @faisalnaveedRNS |
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change