Feat/maintenance mode #1347
Feat/maintenance mode #1347
Conversation
Amean
requested review from
faddat,
MikeSofaer,
faisalnaveedRNS,
kjawadDeveloper2 and
afti-githobo
as code owners
…t/maintenance_mode
…t/maintenance_mode
| @@ -285,6 +320,19 @@ class HomeScreenState extends State<HomeScreen> with SingleTickerProviderStateMi | |||
| width: 20.w, | |||
| )), | |||
| ), | |||
| if (remoteConfigService.getMaintenanceMode()) | |||
| Positioned( | |||
There was a problem hiding this comment.
Is it possible to create a widget called MaintenanceBanner and use it everywhere?
|
@Amean can you add the widget test for the banner ? |
| child: Text( | ||
| LocaleKeys.maintenance_mode_header.tr(), | ||
| style: TextStyle( | ||
| color: Colors.white, fontSize: 10.sp, fontWeight: FontWeight.w700), |
There was a problem hiding this comment.
format this code.
| if (remoteConfigService.getMaintenanceMode()) | ||
| Positioned( | ||
| top: 0.16.sh, | ||
| right: 0, |
| import 'package:flutter_screenutil/flutter_screenutil.dart'; | ||
|
|
||
| import '../generated/locale_keys.g.dart'; | ||
| import '../utils/constants.dart'; |
There was a problem hiding this comment.
Use absolute path instead of relative one.
There was a problem hiding this comment.
Good suggestion i will add a linter for this.
| @@ -22,6 +23,7 @@ import 'package:pylons_wallet/utils/screen_responsive.dart'; | |||
| import 'package:pylons_wallet/utils/svg_util.dart'; | |||
|
|
|||
| import '../../generated/locale_keys.g.dart'; | |||
| import '../../services/third_party_services/remote_config_service/remote_config_service.dart'; | |||
There was a problem hiding this comment.
Use absolute path
| @@ -171,6 +177,12 @@ class HomeScreenState extends State<HomeScreen> with SingleTickerProviderStateMi | |||
| width: 20.w, | |||
| )), | |||
There was a problem hiding this comment.
code formatting not done properly
| @@ -18,6 +18,9 @@ abstract class RemoteConfigService { | |||
|
|
|||
| /// This method returns the ios app version in the remote config | |||
| String getIOSAppVersion(); | |||
|
|
|||
| /// This method returns whether the app is in maintenance mode or not | |||
There was a problem hiding this comment.
Update documentation it should be like this
/// This method tells whether the app is in maintenance mode or not
/// Output: return [bool] true if in maintenance mode else will return false
Adds a banner and message whenever app is in maintenance mode, maintenance mode is toggled by setting maintenanceMode to true in home.dart, #1295