Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working branch cleanup #1338

Merged
merged 5 commits into from
Nov 3, 2022
Merged

Working branch cleanup #1338

merged 5 commits into from
Nov 3, 2022

Conversation

afti-githobo
Copy link
Contributor

Description

Fixes all the borked imports that were causing the working branch to be red forever.

This does not actually make anything use the new APIs; Easel and the wallet still use the old, low-level API and will unless/until someone decides to change that. Using API2 is gonna be a reasonable amount of refactoring, so that's gonna have to be a deliberate thing.

This also doesn't switch the SDK example project over to API2; it should but after thinking about that, I don't want to do that until API2 can actually support all of the operations the example project performs. At present, it kinda just narrowly does things a well-behaved "game" would do, and I don't want to have the example project mix-and-match APIs. So I'm putting that rewrite off until API2 supports creating/updating recipes and doing things w/ trades.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@afti-githobo afti-githobo merged commit 1ed2389 into api2_working Nov 3, 2022
@afti-githobo afti-githobo deleted the working_branch_cleanup branch November 3, 2022 15:01
@zube zube bot removed the [zube]: Done label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants