NFT Listing Full Screen View (pylons app) #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix-1120: changed pylonToUsdConstant to 0.10 from 0.01
ahmadhassan-dev1
requested review from
faddat,
mustafapylons,
MikeSofaer,
faisalnaveedRNS,
kjawadDeveloper2 and
Amean
as code owners
# Conflicts: # wallet/lib/pages/purchase_item/purchase_item_screen.dart # wallet/lib/services/third_party_services/share_helper.dart # wallet/test/widget_testing/components/buttons/nft_buy_button_test.dart
…ysis and refactor test cases
kjawadDeveloper2
requested changes
Oct 21, 2022
|
@kjawadDeveloper2 Kindly review the changes |
kjawadDeveloper2
requested changes
Oct 25, 2022
wallet/test/widget_testing/components/buttons/nft_buy_button_test.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # wallet/i18n/de.json # wallet/i18n/en.json # wallet/i18n/es.json # wallet/i18n/id.json # wallet/i18n/ja.json # wallet/i18n/ko.json # wallet/i18n/ru.json # wallet/i18n/vi.json # wallet/lib/pages/detailed_asset_view/owner_view.dart # wallet/lib/pages/detailed_asset_view/widgets/tab_fields.dart # wallet/lib/pages/purchase_item/purchase_item_screen.dart # wallet/lib/pages/purchase_item/widgets/buy_nft_button.dart # wallet/test/widget_testing/components/buttons/nft_buy_button_test.dart
# Conflicts: # wallet/i18n/de.json # wallet/i18n/en.json # wallet/i18n/es.json # wallet/i18n/id.json # wallet/i18n/ja.json # wallet/i18n/ko.json # wallet/i18n/ru.json # wallet/i18n/vi.json # wallet/lib/pages/home/currency_screen/model/ibc_coins.dart
# Conflicts: # wallet/lib/pages/detailed_asset_view/owner_view_view_model.dart # wallet/lib/pages/purchase_item/purchase_item_view_model.dart # wallet/test/mocks/mock_constants.dart # wallet/test/widget_testing/components/buttons/nft_buy_button_test.dart
|
@ahmadrns Please discuss |
kjawadDeveloper2
requested changes
Nov 4, 2022
wallet/test/widget_testing/components/buttons/nft_buy_button_test.dart
Outdated
Show resolved
Hide resolved
wallet/test/widget_testing/components/buttons/nft_buy_button_test.dart
Outdated
Show resolved
Hide resolved
kjawadDeveloper2
requested changes
Nov 7, 2022
wallet/test/widget_testing/components/buttons/nft_buy_button_test.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # wallet/i18n/de.json # wallet/i18n/en.json # wallet/i18n/es.json # wallet/i18n/id.json # wallet/i18n/ja.json # wallet/i18n/ko.json # wallet/i18n/ru.json # wallet/i18n/vi.json # wallet/lib/generated/locale_keys.g.dart
kjawadDeveloper2
approved these changes
Nov 8, 2022
Amean
reviewed
Nov 8, 2022
Amean
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issues mentioned in #1166