Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added log events for each screen #1198

Merged
merged 3 commits into from
Oct 5, 2022
Merged

Added log events for each screen #1198

merged 3 commits into from
Oct 5, 2022

Conversation

kjawadDeveloper2
Copy link
Collaborator

  1. Added log events for wallet.
  2. Added colors in the AppColors class.

@kjawadDeveloper2 kjawadDeveloper2 marked this pull request as ready for review October 4, 2022 20:13
@heyitsjk
Copy link

heyitsjk commented Oct 4, 2022

on the surface, this looks right to me - analytics-wise. only way to tell is roll it out and see what firebase gives us

mustafapylons
mustafapylons approved these changes Oct 4, 2022
View reviewed changes
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kjawadDeveloper2 kjawadDeveloper2 merged commit c3cd45c into main Oct 5, 2022
@kjawadDeveloper2 kjawadDeveloper2 deleted the feat/wallet_screen_events branch October 5, 2022 15:53
@zube zube bot removed the [zube]: Done label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faisalnaveedRNS faisalnaveedRNS faisalnaveedRNS approved these changes

@mustafapylons mustafapylons mustafapylons approved these changes

@faddat faddat Awaiting requested review from faddat

@MikeSofaer MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjawadDeveloper2 @heyitsjk @faisalnaveedRNS @mustafapylons