Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Audio Playback UI issue and invalid direction to draft after pu… #1189

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Fixed Audio Playback UI issue and invalid direction to draft after pu… #1189

merged 3 commits into from
Oct 4, 2022

Conversation

faizhashmiRnS
Copy link
Contributor

@faizhashmiRnS faizhashmiRnS commented Oct 4, 2022 •
edited by zube bot
Loading

@kjawadDeveloper2
Copy link
Collaborator

A code with test. We are going in a correct direction.

@kjawadDeveloper2 kjawadDeveloper2 marked this pull request as ready for review October 4, 2022 15:38
@kjawadDeveloper2 kjawadDeveloper2 merged commit 565962f into main Oct 4, 2022
@kjawadDeveloper2 kjawadDeveloper2 deleted the fix/easel_audio_ui branch October 4, 2022 16:19
mustafapylons
mustafapylons reviewed Oct 4, 2022
View reviewed changes
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zube zube bot removed the [zube]: Done label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustafapylons mustafapylons mustafapylons left review comments

@faddat faddat faddat approved these changes

@kjawadDeveloper2 kjawadDeveloper2 kjawadDeveloper2 approved these changes

@MikeSofaer MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

@faisalnaveedRNS faisalnaveedRNS Awaiting requested review from faisalnaveedRNS faisalnaveedRNS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faizhashmiRnS @kjawadDeveloper2 @faddat @mustafapylons @ahmadhassan-dev1