Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated test and added get execution logic #1090

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Updated test and added get execution logic #1090

merged 2 commits into from
Sep 20, 2022

Conversation

kjawadDeveloper2
Copy link
Collaborator

  1. Added test
  2. Added logic for parsing of execution on the sdk side.
  3. Added logic for sending of execution on successful execution.

@kjawadDeveloper2 kjawadDeveloper2 marked this pull request as ready for review September 19, 2022 20:51
@kjawadDeveloper2 kjawadDeveloper2 mentioned this pull request Sep 19, 2022
Closed
19 tasks
mustafapylons
mustafapylons approved these changes Sep 19, 2022
View reviewed changes
Copy link

@mustafapylons mustafapylons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

faddat
faddat approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@faddat faddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we are adding some tests for dart!

go formalization!

<3

@faddat faddat merged commit 734b31a into main Sep 20, 2022
@faddat faddat deleted the fix/executions_will_return_execution branch September 20, 2022 13:42
@zube zube bot removed the [zube]: Done label Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faddat faddat faddat approved these changes

@mustafapylons mustafapylons mustafapylons approved these changes

@MikeSofaer MikeSofaer Awaiting requested review from MikeSofaer MikeSofaer is a code owner

@faisalnaveedRNS faisalnaveedRNS Awaiting requested review from faisalnaveedRNS faisalnaveedRNS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjawadDeveloper2 @faddat @mustafapylons