Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PyClassBorrowChecker thread safe #4544

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Make PyClassBorrowChecker thread safe #4544

wants to merge 9 commits into from
+95 −27

Commits on Sep 10, 2024

  1. use a mutex in PyClassBorrowChecker

    @ngoldbaum
    ngoldbaum committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2ec0f70 View commit details
    Browse the repository at this point in the history

  2. add a test that triggers a reference race

    @ngoldbaum
    ngoldbaum committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    46ad34c View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. make BorrowFlag wrap an AtomicUsize

    @ngoldbaum
    ngoldbaum committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9957aca View commit details
    Browse the repository at this point in the history

  2. fix errors seen on CI

    @ngoldbaum
    ngoldbaum committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fb19488 View commit details
    Browse the repository at this point in the history

  3. add changelog entry

    @ngoldbaum
    ngoldbaum committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c687433 View commit details
    Browse the repository at this point in the history

  4. use a compare-exchange loop in try_borrow

    @ngoldbaum
    ngoldbaum committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d36e468 View commit details
    Browse the repository at this point in the history

  5. move atomic increment implementation into increment method

    @ngoldbaum
    ngoldbaum committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c2892c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. fix bug pointed out in code review

    @ngoldbaum
    ngoldbaum committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    721cb9d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. make test use an atomic

    @ngoldbaum
    ngoldbaum committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    d92e733 View commit details
    Browse the repository at this point in the history