Updates the Mouse Wheel to allow for more than 1 axis #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mouse wheel event previously had an `amount` property, which represented the movement on the Y axis of a mouse wheel (the up/down motion). However, many devices support more than 1 axis (such as side scrolling), and so this is now represented by the properties `deltaX`, `deltaY`, and `deltaZ`. The 2 parameter constructor and deconstructor remain the same (assigning the `amount` to the `deltaY`), and so the tests for this remain the same. This is, however, a breaking change, with anyone who currently uses the `amount` property needing to change that accessor to `deltaY`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mouse wheel event previously had an
amountproperty, which represented the movement on the Y axis of a mouse wheel (the up/down motion). However, many devices support more than 1 axis (such as side scrolling), and so this is now represented by the propertiesdeltaX,deltaY, anddeltaZ.The 2 parameter constructor and deconstructor remain the same (assigning the
amountto thedeltaY), and so the tests for this remain the same.This is, however, a breaking change, with anyone who currently uses the
amountproperty needing to change that accessor todeltaY.