Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures fonts are auto-generated correctly #686

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

hobnob
Copy link
Member

@hobnob hobnob commented Feb 5, 2024

This ensures that font files are loaded as Font asset types and also gives direct access to the FontFamily for that font. Supported fonts are ttf, woff, and woff2

Copy link
Member

@davesmith00000 davesmith00000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, I don't have answers just yet. The solution is nearly there, I'm just worried about how all the naming lines up.

Copy link
Member

@davesmith00000 davesmith00000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hobnob, sorry I've been slow to sort this out. I've tested it and it appears to work just fine. 👍

@davesmith00000 davesmith00000 merged commit e2c7014 into main Feb 17, 2024
2 checks passed
@davesmith00000 davesmith00000 deleted the bugfix/generatedFonts branch February 17, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants