Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep Markup: the markup is removed if it's the last element #1618

Open
ggrossetie opened this issue Nov 18, 2018 · 0 comments
Open

Keep Markup: the markup is removed if it's the last element #1618

ggrossetie opened this issue Nov 18, 2018 · 0 comments
Labels
bug help wanted plugins

Comments

@ggrossetie
Copy link
Contributor

I don't if this is intended or not but if the markup (in the exemple below <div class="keep"></div>") is the last element, the Keep Markup plugin will remove it:

<!DOCTYPE html>
<html>
  <head>
    <link href="prism.css" rel="stylesheet" />
    <style>
    .keep {
      height: 1rem;
      width: 1rem;
      background-color: red;
    }
    </style>
  </head>
  <body>
    <pre><code class="language-css"><div class="keep"></div>p { color: red }<div class="keep"></div></code></pre>
    <script src="prism.js"></script>
  </body>
</html>

And here's the result:

error

As you can see the first <div class="keep"></div> is preserved but the last is removed.
If I add some content after the div then it's working as expected:

good
ggrossetie added a commit to ggrossetie/prism that referenced this issue Nov 19, 2018
@ggrossetie
Resolves PrismJS#1618, preserve the markup if it's the last element
7e3b60b
@RunDevelopment RunDevelopment mentioned this issue Nov 30, 2018
Closed
ggrossetie added a commit to ggrossetie/prism that referenced this issue Mar 14, 2019
@ggrossetie
Resolves PrismJS#1618, preserve the markup if it's the last element
3d9ab76
ggrossetie added a commit to ggrossetie/prism that referenced this issue Mar 14, 2019
@ggrossetie
Resolves PrismJS#1618, preserve the markup if it's the last element
9495b20
ggrossetie added a commit to ggrossetie/prism that referenced this issue Mar 14, 2019
@ggrossetie
Resolves PrismJS#1618, preserve the markup if it's the last element
a3c8300
ggrossetie added a commit to ggrossetie/prism that referenced this issue Mar 14, 2019
@ggrossetie
Resolves PrismJS#1618, preserve the markup if it's the last element
b16ecae
@Golmote Golmote mentioned this issue May 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted plugins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggrossetie @RunDevelopment