Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightgcn fix #606

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Lightgcn fix #606

merged 8 commits into from
Mar 25, 2024

Conversation

theisjendal
Copy link
Contributor

Description

Refactoring resulted in double normalization of the first layer as mentioned here: #600 (comment)

Related Issues

Checklist:

  • I have added tests.
  • I have updated the documentation accordingly.
  • I have updated README.md (if you are adding a new model).
  • I have updated examples/README.md (if you are adding a new example).
  • I have updated datasets/README.md (if you are adding a new dataset).

theisjendal and others added 8 commits March 14, 2024 09:45
Removed normalization for layers, not used for lgcn.
Fixed sum weight constant to num layers instead of cur layer index.
Allow lgcn to take blocks.
Fixed requirement error caused by newer dgl versions.
Moved edge normalization to graph for easier use.
@tqtg tqtg added the bug Something isn't working label Mar 25, 2024
@tqtg tqtg merged commit 91ed98c into PreferredAI:master Mar 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants