Add ANN search using HNSWLib #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tqtg , thank you very much for this contribution. I am having a look at it. Please give me sometime to share my feedback by this Saturday. Thank you! |
|
@saghiles any comments on this? |
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
saghiles
reviewed
Nov 13, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Providing a way to do approximate nearest neighbor search using HNSWLib. Having backbone to support other frameworks (e.g., annoy) in the future. In order for a model to support ANN search, it should be an
ANNMixinwith the following functions implemented:get_measure()get_user_vectors()get_item_vectors()Related Issues
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).