-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/propensity stratified evaluation tutorial #408
Feature/propensity stratified evaluation tutorial #408
Conversation
@saghiles please take a look and see if you have any comments on this PR? |
Hi @amirj, thanks for your contribution to Cornac, and congratulation for the good work on propensity stratified evaluation. I went through the tutorial and my overall feedback is as follows. The current version reads more like a usage example of the If you think that this may require significant efforts and may take some time to do, I would recommend leveraging the material (code) of the current tutorial to make an example first. Please see Cornac examples format, the example should be a runnable python file supported with comments. If you agree please feel free to create a PR accordingly. We can then integrate a tutorial on propensity-based stratified evaluation once we have enough materials. Please let us know what are your thoughts, and thanks again for your contribution. |
@amirj do you want to convert this into an example first? Maybe we can prepare a more comprehensive tutorial in the form of notebook with more materials and guiding explanation for users? |
I just did some minor changes and updated the docs. Overall, I'm good with the example. @saghiles any further comments? |
The example looks good to me. If @amirj has no further changes we can merge this PR. |
Thanks both. It looks great to me. Nice to see people can easily reproduce propensity-based stratified evaluation for any model available in Cornac framework :-) |
Since there are no more updates, I'll go ahead and merge this PR. Thanks all! |
Description
I just added a new tutorial to represent propensity-based stratified evaluation.
Related Issues
Checklist:
README.md
(if you are adding a new model).examples/README.md
(if you are adding a new example).datasets/README.md
(if you are adding a new dataset).