Add ComparER models #392
Merged
Add ComparER models #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lthoang isn't better to have two variants merged into one model |
|
@tqtg Two variants build upon two different base models, they use different set of parameters. It should be clearer and easier to maintain. |
|
@lthoang yes, but they can be organized under one module. We don't have to separate them into two completely different modules. |
|
@tqtg I put both variants into |
|
@lthoang you've changed the |
|
@tqtg checked. |
tqtg
approved these changes
Mar 9, 2021
tqtg
pushed a commit
to amirj/cornac
that referenced
this pull request
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).