Make database parameter optional in ConnectionComponents #15511 #15553
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Taarit
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
github-actions
bot
added
bug
zzstoatzz
requested changes
Oct 1, 2024
There was a problem hiding this comment.
thank you for the PR @Ben-Taarit - I think we'll need to accommodate this change elsewhere in the code / tests
| @@ -103,7 +103,9 @@ class ConnectionComponents(BaseModel): | |||
| driver: Union[AsyncDriver, SyncDriver, str] = Field( | |||
| default=..., description="The driver name to use." | |||
| ) | |||
| database: str = Field(default=..., description="The name of the database to use.") | |||
| database: Optional[str] = Field( | |||
| default=None description="The name of the database to use." | |||
There was a problem hiding this comment.
I think there will be some implications associated with this being optional now
Suggested change
| default=None description="The name of the database to use." | |
| default=None, description="The name of the database to use." |
zzstoatzz
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15511