Enhancement: /ui-settings subpathing
#11701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znicholasbrown
requested review from
pleek91,
zangell44 and
a team
as code owners
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pleek91
approved these changes
Jan 22, 2024
|
Thank you! :) |
znicholasbrown
deleted the
nicholas/enhancement-ui-settings-subpathing-2024-01-22
branch
|
waited for this feature for so longgggggg. thanks!!!1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing with the theme of customizing the UI serve functionality, this PR reintroduces the customizable base path when hitting the
/ui-settingsendpoint. Since we're not setting a root path on the fast api app and are instead mounting the directory on the serve base endpoint we need to explicitly interpolate the base url to the/ui-settingsrouteConfirmed when looking at devtools:
cc @danielhstahl I think this is functionality you were looking for at one point that we had to roll back (this no longer has the refresh problem)