Run helm tests also when upgrading chart #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sami-alajrami
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
LGTM
there was a time when tests were triggering upgrade even if the core chart deployment wasn't changing (e.g. tests creating pods with some random names/labels/etc).
Hopefully, that won't be the case now after all the changes in helmsman. helm and helm-diff. But it is worth checking that before merging :)
|
Yes. I did the basic confirmation and tests changes were not causing the deployment to happen (diff was ignoring it). :-) |
mkubaczyk
added a commit
that referenced
this pull request
Aug 18, 2023
Run helm tests also when upgrading chart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest I don't know why the helm tests were only considered for install action. :-)