-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements #445
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5a26151
reduce number of helm commands for validation to number of chart/vers…
zopa-fareed-dudhia 002e01a
cache some helm command results
zopa-fareed-dudhia 5898e6c
fix appVersion
zopa-fareed-dudhia 0f62379
fix release performancce improvements
zopa-fareed-dudhia 3eb2a47
fix pr feedback and restrict plan to targetted apps
zopa-fareed-dudhia 09dae83
fix variable name
zopa-fareed-dudhia 9035720
revert target for plan
zopa-fareed-dudhia 1b7b45e
Merge branch 'master' into cache-fixes
fmd 0158490
fix missing quote
zopa-fareed-dudhia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,8 +25,8 @@ func helmCmd(args []string, desc string) command { | |
} | ||
|
||
// extractChartName extracts the Helm chart name from full chart name in the desired state. | ||
func extractChartName(releaseChart string, version string) string { | ||
cmd := helmCmd([]string{"show", "chart", releaseChart, "--version", version}, "Show chart information for version "+version) | ||
func extractChartName(releaseChart string) string { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I reverted this change -- we no longer use this when we already have a version |
||
cmd := helmCmd([]string{"show", "chart", releaseChart}, "Extracting chart information for [ "+releaseChart+" ]") | ||
|
||
result := cmd.exec() | ||
if result.code != 0 { | ||
|
@@ -53,6 +53,7 @@ func getHelmVersion() string { | |
if result.code != 0 { | ||
log.Fatal("While checking helm version: " + result.errors) | ||
} | ||
|
||
return result.output | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably using a struct for the extracted chart names and versions would be cleaner but I guess we can do that in another iteation