Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DRY-ed Example #425

Merged
merged 8 commits into from
Apr 8, 2020
Merged

Add DRY-ed Example #425

merged 8 commits into from
Apr 8, 2020

Conversation

Xtigyro
Copy link
Contributor

@Xtigyro Xtigyro commented Mar 28, 2020

No description provided.

@Xtigyro Xtigyro changed the title Add Complete and DRY-ed Example Add DRY-ed Example Mar 28, 2020
Copy link
Contributor

@sami-alajrami sami-alajrami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Xtigyro for providing this missing example.
I would rather name the readme and the directories as AppsTemplates than dried. Additionally, it would be nice to explain in the readme that you would use the appsTemplates to use named templates and achieve DRY. It is worth mentioning also, that this would work on YAML desired state files and not with TOML (unless if I am wrong).
Finally, it would be great to link this readme/example in this docs landing page (under Misc) to make it easier to find https://github.com/Praqma/helmsman/tree/master/docs/how_to

examples/dried-example/README.md Outdated Show resolved Hide resolved
@Xtigyro
Copy link
Contributor Author

Xtigyro commented Mar 30, 2020

thanks @Xtigyro for providing this missing example.
I would rather name the readme and the directories as AppsTemplates than dried. Additionally, it would be nice to explain in the readme that you would use the appsTemplates to use named templates and achieve DRY. It is worth mentioning also, that this would work on YAML desired state files and not with TOML (unless if I am wrong).
Finally, it would be great to link this readme/example in this docs landing page (under Misc) to make it easier to find https://github.com/Praqma/helmsman/tree/master/docs/how_to

Thanks for the so detailed and nice feedback, @sami-alajrami!
Will work on it and let ya know (when ready).

@Xtigyro
Copy link
Contributor Author

Xtigyro commented Apr 4, 2020

@sami-alajrami Hey - do you think it's ready now?

@sami-alajrami sami-alajrami merged commit ff00b76 into Praqma:master Apr 8, 2020
@Xtigyro Xtigyro deleted the feature/add-full-dried-example branch April 15, 2020 12:02
mkubaczyk pushed a commit that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants