Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to standard output and Slack messages #410

Merged
merged 15 commits into from
Feb 10, 2020
Merged

Changes to standard output and Slack messages #410

merged 15 commits into from
Feb 10, 2020

Conversation

sharkymcdongles
Copy link
Contributor

This adds version to the standard output to show what version is being installed/upgraded.

This improves slack output to not use pretext to prevent it from being cut off.

@sharkymcdongles
Copy link
Contributor Author

I think this is to a point where it can be reviewed.

if content == "" {
pretext = "No actions to perform!"
pretext = "*No actions to perform!*"
contentBold = content
Copy link
Collaborator

@luisdavim luisdavim Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: At this point both variables are empty strings, this line seems redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and removed it as suggested.

@luisdavim
Copy link
Collaborator

Why make everything bold?

@sharkymcdongles
Copy link
Contributor Author

Why make everything bold?

The original code used the pretext field for displaying the plan, and pretext is bold by design. I just assumed you'd want to mirror the same bolding that was there. I can change it to whatever you guys think is best. I just extended what was there with no real plan except mirroring the original functionality best I could while adding some stuff. Please let me know what formatting you prefer.

As for the redundant bit, I will commit changes tomorrow to remedy that mistake on my part.

Thanks for the reply!

Copy link
Contributor Author

@sharkymcdongles sharkymcdongles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the suggested line. Please let me know if you'd like me to change formatting in any way.

if content == "" {
pretext = "No actions to perform!"
pretext = "*No actions to perform!*"
contentBold = content
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and removed it as suggested.

@luisdavim luisdavim merged commit 37046db into Praqma:master Feb 10, 2020
mkubaczyk pushed a commit that referenced this pull request Aug 18, 2023
Changes to standard output and Slack messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants