-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to standard output and Slack messages #410
Conversation
…ell for slack footer
I think this is to a point where it can be reviewed. |
internal/app/utils.go
Outdated
if content == "" { | ||
pretext = "No actions to perform!" | ||
pretext = "*No actions to perform!*" | ||
contentBold = content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: At this point both variables are empty strings, this line seems redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and removed it as suggested.
Why make everything bold? |
The original code used the pretext field for displaying the plan, and pretext is bold by design. I just assumed you'd want to mirror the same bolding that was there. I can change it to whatever you guys think is best. I just extended what was there with no real plan except mirroring the original functionality best I could while adding some stuff. Please let me know what formatting you prefer. As for the redundant bit, I will commit changes tomorrow to remedy that mistake on my part. Thanks for the reply! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the suggested line. Please let me know if you'd like me to change formatting in any way.
internal/app/utils.go
Outdated
if content == "" { | ||
pretext = "No actions to perform!" | ||
pretext = "*No actions to perform!*" | ||
contentBold = content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and removed it as suggested.
Changes to standard output and Slack messages
This adds version to the standard output to show what version is being installed/upgraded.
This improves slack output to not use pretext to prevent it from being cut off.