add resource quotas

[ivelichkovich]

refactored version of this #340, we're going to use helm3 and helmsman3 so don't need tiller resources so just resource quotas

[luisdavim]

Why not just marshal the object like it's done in the setLimits method instead of setting each field?

[ivelichkovich]

I just copy pasted what I had from the old PR before helm 3, will change

[ivelichkovich]

Looking at it, the marshalling won't work because it isn't the exact same object format because of the customResources option

[luisdavim]

what matters is the format we use in the Helmsman file and the struct format we use to unmarshal, we can make them match, like it's done in the setLimits function....

[ivelichkovich]

No we can't because of the customResources field, that can be anything, like gpu's or something custom, so we can't have that because the struct would need to be dynamic

[ivelichkovich]

requests.nvidia.com/gpu I guess is a standard one, although not very common so I didn't include it but you can have resource quotas on completely custom resources such as count/widgets.example.com or wheels/custom.com

[luisdavim]

Sure, but all the other parts can be marshaled and this appended at the end like you are doing now.

[ivelichkovich]

so two questions

1, how would I tell it to marshal everything but the customResources?

2, this is what the actual yaml looks like for k8s
status:

  hard:    
    limits.cpu: "10" 
    limits.memory: 8Gi 
    pods: "25" 
    requests.cpu: "10" 
    requests.memory: 8Gi 

So I would have to change the structure of the helmsman yaml, we can do that but I think it'd be a little weird to have the dot notation and I would need to know the answer to question 1 to be able to do that.

If I'm understanding correctly you'd want me to marshal Limits and Resources

  hard:  
    limits:   
       cpu: "10" 
       memory: "8Gi" 
    pods: "25" 
    requests:  
        cpu: "10"  
        memory: 8Gi 

but the actual k8s yaml doesn't look like that.

[ivelichkovich]

@luisdavim hey this should be resolved now, sorry my day job was very busy this last month. Let me know if the way I handled not marshaling the custom quotas is okay

[mkubaczyk]

Looks good overall, small requests from me though.
Can you come up with at least 1-2 test cases? We'd like to be sure the outcome yaml for quotas is fine and also that we can handle at least one example of improperly defined quotas. :-)

[mkubaczyk]

I'd rather put this line before we run log.Fatal for result.code != 0 so the file "always" gets deleted even when kubectl apply failed

[mkubaczyk]

Also you might want to use this catalog https://github.com/Praqma/helmsman/blob/master/internal/app/main.go#L10 for such file

[mkubaczyk]

You can set it as 3.2.0, I hope this will go with next minor release

[luisdavim]

Hi @ivelichkovich would you be able to address @mkubaczyk's comments?
Thanks.

[ivelichkovich]

Yes working on it now, should be an hour or two

[ivelichkovich]

Updated per the requests and I added quotas into the examples/example.toml (which is a file used in testing),
I'm not sure how to create tests for the setQuotas method without a big refactor of the rest of the code because I can't mock out the call to kubectl or the log.fatal, if there's a better way to mock or any ideas I'd be happy to implement them

[mkubaczyk]

just change the version in docs and we can merge it :-)