Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose the inline prediction color based on the environment #3808

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Sep 21, 2023

PR Summary

Fix #3805

Choose the inline prediction color based on the environment. On Windows OS prior to Win11, if it's not running in Windows Terminal, then we use the old inline color that was used in v2.2.6. Otherwise, we use the new color, which provide sufficient contrast in terminals that don't use a pure black background (like VSCode terminal). See #3493 for the color change.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw daxian-dbw merged commit d045b50 into PowerShell:master Sep 26, 2023
2 checks passed
@daxian-dbw daxian-dbw deleted the inline-color branch September 26, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline Prediction Colour is white/not dim after 2.3.3 upgrade.
2 participants