Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure time_to_convert bins stay uniform #5316

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Ensure time_to_convert bins stay uniform #5316

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee58cf
ensure bins stay uniform
neilkakkar Jul 23, 2021
968339e
rm offending line
neilkakkar Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ee/clickhouse/queries/funnels/funnel_time_to_convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def get_query(self) -> str:
FROM step_runs
GROUP BY bin_from_seconds
) results
FULL OUTER JOIN (
RIGHT OUTER JOIN (
/* Making sure bin_count bins are returned */
/* Those not present in the results query due to lack of data simply get person_count 0 */
SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds FROM system.numbers LIMIT {bin_count_identifier} + 1
Expand Down