Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Funnel Unordered persons and Testing #4943

Merged
merged 54 commits into from
Jul 1, 2021
Merged

Setup Funnel Unordered persons and Testing #4943

merged 54 commits into from
Jul 1, 2021

Commits on Jun 18, 2021

  1. wip: pagination for persons on clickhouse funnels

    @buwilliams
    buwilliams committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    537bdb3 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. wip: added offset support for getting a list of persons; added suppor… 

    …t for conversion window;
    @buwilliams
    buwilliams committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    605f9de View commit details
    Browse the repository at this point in the history

  2. fixed mypy exception

    @buwilliams
    buwilliams committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    a9a5f12 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. helper function to insert data for local testing

    @buwilliams
    buwilliams committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    e952308 View commit details
    Browse the repository at this point in the history

  2. moved generate code into separate class for more functionality later

    @buwilliams
    buwilliams committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    ceda12e View commit details
    Browse the repository at this point in the history

  3. corrected person_distinct_id to use the person id from postgres

    @buwilliams
    buwilliams committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    1a29fdb View commit details
    Browse the repository at this point in the history

  4. minor corrections to generate local class along with addition of data… 

    … cleanup via destroy() method
    @buwilliams
    buwilliams committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    1990907 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. reduce the number of persons who make it to each step

    @buwilliams
    buwilliams committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    7daeaaa View commit details
    Browse the repository at this point in the history

  2. moved funnel queries to a new folder for better organization; separat… 

    …ed funnel_persons and funnel_trends_persons into individual classes;
    @buwilliams
    buwilliams committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    fba259e View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Merge branch 'master' into funnel-persons-pagination-conversion-window

    @EDsCODE
    EDsCODE committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    cc24758 View commit details
    Browse the repository at this point in the history

  2. funnel persons and tests

    @buwilliams
    buwilliams committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    142e7b6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'funnel-persons-pagination-conversion-window' of github.… 

    …com:PostHog/posthog into funnel-persons-pagination-conversion-window
    @buwilliams
    buwilliams committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    df44123 View commit details
    Browse the repository at this point in the history

  4. initial implementation

    @EDsCODE
    EDsCODE committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    589e937 View commit details
    Browse the repository at this point in the history

  5. invoke the funnel or funnel trends class respectively

    @buwilliams
    buwilliams committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ac6d601 View commit details
    Browse the repository at this point in the history

  6. add a test

    @EDsCODE
    EDsCODE committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    34d5bad View commit details
    Browse the repository at this point in the history

  7. add breakdown handling and first test

    @EDsCODE
    EDsCODE committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    b483277 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. add test stubs

    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    9242414 View commit details
    Browse the repository at this point in the history

  2. remove repeats

    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3042e59 View commit details
    Browse the repository at this point in the history

  3. mypy corrections and PR feedback

    @buwilliams
    buwilliams committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    474ba42 View commit details
    Browse the repository at this point in the history

  4. run funnel test suite on new query implementation

    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    4abecaf View commit details
    Browse the repository at this point in the history

  5. remove imports

    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    62f2919 View commit details
    Browse the repository at this point in the history

  6. corrected tests

    @buwilliams
    buwilliams committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    4fb5a43 View commit details
    Browse the repository at this point in the history

  7. minor test updates

    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    74bfa1b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'funnel-persons-pagination-conversion-window' into funne… 

    …l-step-query-new
    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    0aa36f9 View commit details
    Browse the repository at this point in the history

  9. correct func name

    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5c9dcd2 View commit details
    Browse the repository at this point in the history

  10. fix types

    @EDsCODE
    EDsCODE committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5df0cad View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. merge master

    @EDsCODE
    EDsCODE committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    d7d2e60 View commit details
    Browse the repository at this point in the history

  2. unordered step and test

    @neilkakkar
    neilkakkar committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    a9e9b7f View commit details
    Browse the repository at this point in the history

  3. func name change

    @EDsCODE
    EDsCODE committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    0427159 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. move builder functions to funnel base

    @EDsCODE
    EDsCODE committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    b9cae01 View commit details
    Browse the repository at this point in the history

  2. add test classe for new funnel

    @EDsCODE
    EDsCODE committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7c5e606 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into funnel-step-query-new

    @EDsCODE
    EDsCODE committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    49f8c92 View commit details
    Browse the repository at this point in the history

  4. resolve issues with unordered funnel

    @neilkakkar
    neilkakkar committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    0938b92 View commit details
    Browse the repository at this point in the history

  5. resolve merge conflicts

    @neilkakkar
    neilkakkar committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    4420421 View commit details
    Browse the repository at this point in the history

  6. oops

    @neilkakkar
    neilkakkar committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    ae21c8c View commit details
    Browse the repository at this point in the history

  7. remove breakdown, fix mypy error

    @neilkakkar
    neilkakkar committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    b3fa339 View commit details
    Browse the repository at this point in the history

  8. Handle multiple same events in the funnel (#4863) 

    * dedup + tests

* deep equality. Tests to come

* write test for entity equality

* finish testing funnels

* clean up comments
    @neilkakkar
    neilkakkar authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    716e8af View commit details
    Browse the repository at this point in the history

  9. Merge branch 'funnel-step-query-new' of github.com:PostHog/posthog in… 

    …to funnel-unordered-step
    @neilkakkar
    neilkakkar committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    79cbea2 View commit details
    Browse the repository at this point in the history

  10. from O(2^N) to O(N)

    @neilkakkar
    neilkakkar committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    6c4245f View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. merge master

    @EDsCODE
    EDsCODE committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    6d1f8f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. add query intuition blurb

    @neilkakkar
    neilkakkar committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    001a149 View commit details
    Browse the repository at this point in the history

  2. rm todo

    @neilkakkar
    neilkakkar committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    1372f68 View commit details
    Browse the repository at this point in the history

  3. wip persons

    @neilkakkar
    neilkakkar committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    a54db4e View commit details
    Browse the repository at this point in the history

  4. wip persons 2

    @neilkakkar
    neilkakkar committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    7857487 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Merge branch 'master' of github.com:PostHog/posthog into funnel-unord… 

    …ered-step
    @neilkakkar
    neilkakkar committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    74e72cd View commit details
    Browse the repository at this point in the history

  2. address comments

    @neilkakkar
    neilkakkar committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    1bfa011 View commit details
    Browse the repository at this point in the history

  3. merge master

    @neilkakkar
    neilkakkar committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    aa71b6d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'funnel-unordered-step' of github.com:PostHog/posthog in… 

    …to funnel-unordered-persons
    @neilkakkar
    neilkakkar committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    9b8df58 View commit details
    Browse the repository at this point in the history

  5. test things, fix bugs

    @neilkakkar
    neilkakkar committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    c46dc07 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. resolve merge conflicts

    @neilkakkar
    neilkakkar committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    a11eeed View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into funnel-unordered-persons

    @neilkakkar
    neilkakkar authored Jul 1, 2021
    Configuration menu
    Copy the full SHA
    f4d9b58 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into funnel-unordered-persons

    @EDsCODE
    EDsCODE committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    a13add8 View commit details
    Browse the repository at this point in the history

  4. match result format to funnel.py

    @EDsCODE
    EDsCODE committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    d330e34 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into funnel-unordered-persons

    @EDsCODE
    EDsCODE committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    2d9ea97 View commit details
    Browse the repository at this point in the history