Miscellaneous fixes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes by Jim Klassen: In GDAL 3.x `geom.ExportToWkt()` may return coordinates formatted as integers (in the case that they actually fall on an integer). Previous GDAL versions appear to have always formatted the coordinates as floats (with a decimal point). This broke the regex used to parse the x-coordinates out of the WKT. For example, the `-72` below was being skipped by the regex: ``` POLYGON (( -102.439166666667 -72.3713888888889 0, -103.113055555556 -72.3983333333333 0, -103.104166666667 -72.0288888888889 0, -102.446388888889 -72 0, -102.439166666667 -72.3713888888889 0 )) ``` Instead of exporting to WKT and trying to parse the WKT into floats, loop over the rings of the polygon and then the points of the rings to extract the floating point X-coordinates directly using GetX().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taskhandler. Changed to a new strategy that should be less prone to error in the future.doesCross180method of retrieving geometry point coordinates from old regex parsing of the WKT string to a more robust method of retrieving the coordinates through GDAL methods. The new method passestests/unit_test_utils.py. Thanks @klassenjs!collectionsmodule in theutils.yield_task_argsmethod is now backwards-compatible with Python2 so that we can test issues with Nunatak job scheduler that may be present when running with a Python3/GDAL3 Conda environment but not present when using the oldmodule load gdal/2.1.3environment.