Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gdalwarp --tap argument, couple bugfixes #37

Merged
merged 6 commits into from
Jun 15, 2021
Merged

Conversation

ehusby
Copy link
Contributor

@ehusby ehusby commented Jun 4, 2021

Fixed a math order of operations bug in automatic stretch option --stretch='au', and re-enabled use of that option by adding 'au' to the list of --stretch choices.

pgc_pansharpen.py would throw unwarranted/misleading error messages, one for every panchromatic image in the source directory, such as this:

RuntimeError: Image does not match multispectral name pattern: WV03_20150520204559_104001000C4A2100_15MAY20204559-P1BS-500827654050_01_P001.ntf

I reworked the error-catching logic to filter out reporting panchromatic images that are part of matched pan/multi pairs. All unmatched images should still be reported.

Unwarranted error message was being thrown for every panchromatic image: "Image does not match multispectral name pattern".
Now all unpaired/unmatched images will be displayed in a single error message.
@ehusby
Copy link
Contributor Author

ehusby commented Jun 8, 2021

@clairecporter Does the automatic stretch (--stretch='au') feature still look good to you? One of the bugfixes involved the latitude calculation for that.
Currently that options does this: au: automatically set (rf for images below 60S latitude, otherwise mr)

I'm not sure if you realized that the au choice was actually disabled up until now, since it was missing from the choices list for the stretch argument.

I'd like to merge this PR fairly soon, since it touches some of the external GDAL commands that I figure @bagl0025 would need to modify in converting to in-memory raster handling.

Copy link
Member

@clairecporter clairecporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ehusby ehusby merged commit 38c037b into master Jun 15, 2021
@ehusby ehusby deleted the ortho-fixes branch June 15, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants