Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gdal version to 2.1.3 in qsub scripts to resolve numpy issue #28

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

bakkerbakker
Copy link
Contributor

Testing the PR workflow with a quick fix to the GDAL version called in the qsub .sh scripts. The 2.1.1 version of the GDAL module did not have numpy installed, which caused the pgc_mosaic.py script to fail with the -pbs flag. Upon Erik's advice, I switched to 2.1.3, which resolved the issue.

@ehusby
Copy link
Contributor

ehusby commented Apr 6, 2021

Looks good! When you make a PR that's worth running by other members of the team, typically just tag them under the "Reviewers" section instead of "Assignees" -- the latter should probably be used to appoint someone(s) in particular to make additional changes... (it makes more sense for Issues).

Thanks! Feel free to merge this when you're ready, and then pull changes into the common repo at V:\pgc\data\common\repos\imagery_utils. Typically you could do this either through Nunatak or Windows, but with Nunatak unavailable ATM, just a simple "Git Bash Here" in that folder through Windows followed by git pull should do the trick.

@bakkerbakker
Copy link
Contributor Author

Got it! Somehow I missed Reviewers at the top but my eye landed on Assignees. I'll use Reviewers going forward. Thanks!

Copy link
Member

@clairecporter clairecporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test of the PR workflow. I certainly approve this change. However, while the gdal/2.1.3 module will work fine. I think it's appropriate to move all the qsub files to loading the pgc conda env. If we assume each user has conda installed and the env is named pgc, that can be hard coded. More elegant might be using the qsub -v option to pass through specific environment variables to the spawned job. I will add that as a issue for future work.

@bakkerbakker bakkerbakker merged commit 8fcefac into master Apr 6, 2021
@bakkerbakker bakkerbakker deleted the qsub-gdal-version branch April 6, 2021 21:18
@ehusby
Copy link
Contributor

ehusby commented Apr 6, 2021

Good point @clairecporter. As we run different scripts on the cluster, let's make an effort to test our pgc conda env on a case-by-case basis. Our pgc env uses GDAL version 3, and while hopefully there aren't changes between GDAL v2 and v3 that break scripts (besides the PROJ axis order thing), we should be careful to watch for any oddities in the results.

To test this in qsub scripts, we'd just replace the module load gdal/2.1.3 line with conda activate pgc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants