Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin back setuptools until we can remove distutils #359

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Pin back setuptools until we can remove distutils #359

merged 2 commits into from
Sep 10, 2024

Conversation

timkpaine
Copy link
Member

@timkpaine timkpaine commented Aug 30, 2024 •
edited
Loading

@timkpaine
Pin back setuptools until we can remove distutils
b379890 
Signed-off-by: Tim Paine <Timothy.Paine@CubistSystematic.com>
@timkpaine timkpaine force-pushed the tkp/setuptools branch 2 times, most recently from 2fcda7a to fff9c6a Compare September 3, 2024 16:31
@timkpaine timkpaine marked this pull request as ready for review September 3, 2024 17:55
AdamGlustein
AdamGlustein previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@AdamGlustein AdamGlustein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds are passing

.github/workflows/build.yml Outdated Show resolved Hide resolved
@timkpaine
Work around compiler changes
6018784 
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@timkpaine timkpaine added the part: build Issues and PRs related to the build process label Sep 3, 2024
@AdamGlustein AdamGlustein self-requested a review September 3, 2024 19:58
@timkpaine timkpaine mentioned this pull request Sep 3, 2024
Open
@timkpaine timkpaine merged commit 1ce6f25 into main Sep 10, 2024
29 checks passed
@timkpaine timkpaine deleted the tkp/setuptools branch September 10, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robambalu robambalu robambalu approved these changes

@AdamGlustein AdamGlustein AdamGlustein approved these changes

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@ptomecek ptomecek Awaiting requested review from ptomecek ptomecek is a code owner

Assignees
No one assigned
Labels
part: build Issues and PRs related to the build process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timkpaine @robambalu @AdamGlustein