Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove geojson_4326, add geom_4326 #17

Merged
merged 6 commits into from
Dec 11, 2023
Merged

Remove geojson_4326, add geom_4326 #17

merged 6 commits into from
Dec 11, 2023

Conversation

bouttier
Copy link
Contributor

@bouttier bouttier commented Nov 28, 2023

#6

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (0e8b830) 82.78% compared to head (9c92bac) 81.02%.

Files Patch % Lines
..._geo/migrations/versions/bc2fcc772b46_geom_4326.py 37.50% 15 Missing ⚠️
src/ref_geo/env.py 72.72% 3 Missing ⚠️
...ions/0dfdbfbccd63_ref_geo_french_municipalities.py 0.00% 3 Missing ⚠️
...ersions/3fdaa1805575_ref_geo_french_departments.py 25.00% 3 Missing ⚠️
...ns/versions/d02f4563bebe_ref_geo_french_regions.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
- Coverage    82.78%   81.02%   -1.76%     
===========================================
  Files           22       24       +2     
  Lines          819      875      +56     
===========================================
+ Hits           678      709      +31     
- Misses         141      166      +25     
Flag Coverage Δ
pytest 81.02% <66.25%> (-1.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

And fix LiMunicipalities.id_municipality column type.
@mvergez
Copy link

mvergez commented Dec 1, 2023

Salut !
Ne serait-ce pas possible de plutôt ajouter un INDEX sur ST_Transform(geom, 4326) ?
Niveau perfo vous pensez que ça le ferait ?
Au moins on pourrait avoir qu'une seule colonne géométrique

Thus, add marshmallow schemas for serialization, notably geojson serialization.
@camillemonchicourt
Copy link
Member

Salut ! Ne serait-ce pas possible de plutôt ajouter un INDEX sur ST_Transform(geom, 4326) ? Niveau perfo vous pensez que ça le ferait ? Au moins on pourrait avoir qu'une seule colonne géométrique

Oui c'est un peu ce que suggère Fred sur le ticket lié #6 (comment) 🤔

@jacquesfize
Copy link
Contributor

Salut @bouttier, @mvergez

J'ai enlevé SQLAlchemy 1.3 sur la GH action de pytest. Est-ce que vous avez d'autres modifications à faire ?

@jacquesfize jacquesfize merged commit ac3f4d6 into develop Dec 11, 2023
4 of 6 checks passed
jacquesfize added a commit to PnX-SI/GeoNature that referenced this pull request Dec 19, 2023
In this merge :
 - CustomSelect is now deleted.
 - Almost every SQLA queries are now in 2.0 style  
 - Include ref_geo update (geojson_4326 to geom_4326) PnX-SI/RefGeo#17
- Split Dataset and AcquisitionFramework in different files for an easier read
@bouttier bouttier deleted the feat/geom_4326 branch December 21, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants