Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increasing timeout for GameServerBuild controller test #99

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

dgkanatsios
Copy link
Collaborator

@dgkanatsios dgkanatsios commented Dec 6, 2021

Fixes #40
GameServerBuild controller tests are sometimes flaky. This PR increases the timeout for an assertion which gave us problems in the past, e.g. https://github.com/PlayFab/thundernetes/runs/4427358325

Added code from #102

Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dgkanatsios dgkanatsios merged commit fad1502 into master Dec 13, 2021
@dgkanatsios dgkanatsios deleted the fixingunittests branch December 13, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky controller unit test
2 participants