adding logrus to initcontainer #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
commented
Oct 31, 2021
| ## PortsToExpose | ||
|
|
||
| This is a list of containerName/portName tuples: These are the ports that you want to be exposed in the [Worker Node/VM](https://kubernetes.io/docs/concepts/architecture/nodes/) when the Pod is created. The way this works is that each Pod you create will have >=1 number of containers. There, each container will have its own *Ports* definition. If a port in this definition is included in the *portsToExpose* array, this port will be publicly exposed in the Node/VM. This is accomplished by the creation of a **hostPort** value for each of the container ports you want to expose. The reason we need this is that because i) you may want to use some ports on your Pod containers for other purposed than players connecting to it and ii) a portName must be unique within a container. Ports assigned are in the port range 10000-50000. | ||
| # GameServerBuild definition |
There was a problem hiding this comment.
CRLF vs LF again, sorry :(
There was a problem hiding this comment.
always LF :) CRLF takes up twice the space :)
dgkanatsios
commented
Oct 31, 2021
| images: | ||
| - name: controller | ||
| newName: thundernetes-operator | ||
| newTag: 52d2641 |
There was a problem hiding this comment.
this is re-generated every time I run make. We need to better understand what kustomize does during building
dgkanatsios
added
area/user-experiences
dgkanatsios
force-pushed
the
initcontainerlogrus
branch
from
1db41c1
to
7d62309
Compare
khaines
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #36
Added logrus to initcontainer, for structured logging. For better tracking, we needed the namespace of the GameServer CRD so I added a new environment variable to pass it into initcontainer.