Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pull latest cert-manager version #407

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Conversation

snobu
Copy link
Contributor

@snobu snobu commented Sep 22, 2022

Make sure we're always pulling the latest cert-manager by getting the latest release tag from GitHub and passing it to kubectl apply -f.

This may look shady to some users so i'm open to just mentioning "hey go here and check the latest version number and add it to the URL by hand".

Up to you to decide.

@dgkanatsios
Copy link
Collaborator

ping @snobu, we'd love to merge this!

@snobu
Copy link
Contributor Author

snobu commented Oct 3, 2022

I don't really know how the {% include code-block-start.md %} thing works so can only assume it will :)
Also the CI trigger should ignore Markdown files, it's wasted compute. I can send a PR but just checking with you first if it's not intentional.

@dgkanatsios
Copy link
Collaborator

I can send a PR but just checking with you first if it's not intentional.

That would be great, thanks!

@dgkanatsios dgkanatsios merged commit 5b2a014 into PlayFab:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants