Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.0.2.0 #38

Merged
merged 2 commits into from
Oct 19, 2021
Merged

version 0.0.2.0 #38

merged 2 commits into from
Oct 19, 2021

Conversation

dgkanatsios
Copy link
Collaborator

Some recent PRs (e.g. #31) altered some thundernetes functionality so we should release a new version. This PR modifies the .versions file with the new versions plus fixes the Makefile generation that till recently worked on my machine. As soon as this PR is merged, we should run the Publish Container Images workflow to generate the new container images, or else the installation scripts would break.

e2e/run.sh Outdated Show resolved Hide resolved
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to offer the suggestion that we follow symver conventions for numbering.

Along that line, if we are adding new functionality, we should be at version 0.1.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can also be something we chat about before adopting it as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I was thinking about it as well, thanks for bringing this up. When we do the next update, we can do 0.1.0. Thanks!

Copy link
Collaborator

@khaines khaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should updated the current version. See my comment about symver, as this is something we can adopt going forward.

@dgkanatsios dgkanatsios merged commit c5e1ea5 into master Oct 19, 2021
@dgkanatsios dgkanatsios deleted the 0.0.2.0 branch October 19, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants