Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding connected players prometheus gauge #162

Merged
merged 1 commit into from
Feb 16, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions cmd/nodeagent/nodeagentmanager.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ var (
Name: "game_server_states",
Help: "Game server states",
}, []string{"name", "state"})

ConnectedPlayersGauge = promauto.NewGaugeVec(prometheus.GaugeOpts{
Name: "connected_players",
Help: "Number of connected players per GameServer",
}, []string{"namespace", "name"})
)

type NodeAgentManager struct {
Expand Down Expand Up @@ -351,18 +356,24 @@ func (n *NodeAgentManager) updateConnectedPlayersIfNeeded(ctx context.Context, h
if hb.CurrentGameState != GameStateActive || gsd.ConnectedPlayersCount == len(hb.CurrentPlayers) {
return nil
}
currentPlayerIDs := make([]string, len(hb.CurrentPlayers))

connectedPlayersCount := len(hb.CurrentPlayers)

// set the prometheus gauge
ConnectedPlayersGauge.WithLabelValues(gsd.GameServerNamespace, gameServerName).Set(float64(connectedPlayersCount))

currentPlayerIDs := make([]string, connectedPlayersCount)
for i := 0; i < len(hb.CurrentPlayers); i++ {
currentPlayerIDs[i] = hb.CurrentPlayers[i].PlayerId
}
logger.Infof("ConnectedPlayersCount is different than before, updating. Old connectedPlayersCount %d, new connectedPlayersCount %d", gsd.ConnectedPlayersCount, len(hb.CurrentPlayers))

gsdPatchSpec := mpsv1alpha1.GameServerDetailSpec{}
if len(hb.CurrentPlayers) == 0 {
if connectedPlayersCount == 0 {
gsdPatchSpec.ConnectedPlayersCount = 0
gsdPatchSpec.ConnectedPlayers = make([]string, 0)
} else {
gsdPatchSpec.ConnectedPlayersCount = len(hb.CurrentPlayers)
gsdPatchSpec.ConnectedPlayersCount = connectedPlayersCount
gsdPatchSpec.ConnectedPlayers = currentPlayerIDs
}

Expand Down Expand Up @@ -390,7 +401,7 @@ func (n *NodeAgentManager) updateConnectedPlayersIfNeeded(ctx context.Context, h
// storing the current number in memory
gsd.Mutex.Lock()
defer gsd.Mutex.Unlock()
gsd.ConnectedPlayersCount = len(hb.CurrentPlayers)
gsd.ConnectedPlayersCount = connectedPlayersCount

return nil
}
Expand Down