Projects redesign/project details #2183

sunilsabatp · 2024-08-18T12:42:09Z

This PR takes care the Project info section which includes

project card
about us
project review
project info
contact details
dive to map (only for mobile)

how to test ?
visit -> /locale/prd/[project slug]

vercel · 2024-08-18T12:42:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp-multi-tenancy-setup	✅ Ready (Inspect)	Visit Preview		Sep 18, 2024 10:17am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
planet-webapp	⬜️ Ignored (Inspect)			Sep 18, 2024 10:17am
planet-webapp-temp	⬜️ Ignored (Inspect)			Sep 18, 2024 10:17am

coderabbitai · 2024-08-18T12:42:20Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-- I pushed a fix in commit <commit_id>, please review it.
-- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
-- @coderabbitai generate unit testing code for this file.
-- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
-- @coderabbitai generate interesting stats about this repository and render them as a table.
-- @coderabbitai read src/utils.ts and generate unit testing code.
-- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mariahosfeld · 2024-08-26T11:58:35Z

Check again for design consistency.
On mobile: Some components are not taking the same width as others, e.g., the image slider and the video are more width.

mariahosfeld

Looks good to merge. Once in complete context we will need to review fontsizes, some seem quite small.

mohitb35 · 2024-09-14T10:02:34Z

@mariahosfeld I think we need to list down information that should be seen in the project details for conservation and tree projects. We have 2 main sections below the image slider (KeyInfo and AdditionalInfo), and currently KeyInfo is shown only for tree projects. That logic isn't correct, but I think we need a definite list of information that can be seen.

mohitb35

@sunilsabatp Please go through my feedback.

src/temp/icons/DownArrow.tsx

src/temp/icons/UpArrow.tsx

src/temp/stories/projectDetails/MapPreview.stories.tsx

src/features/projectsV2/ProjectDetails/index.tsx

src/features/projectsV2/ProjectSnippet/styles/ProjectSnippet.module.scss

src/features/projectsV2/ProjectDetails/components/ProjectDownloads.tsx

src/features/projectsV2/ProjectDetails/components/microComponents/ProjectSpendingItem.tsx

src/features/projectsV2/ProjectDetails/components/microComponents/ExternalCertificationItem.tsx

src/features/projectsV2/ProjectDetails/components/ProjectDownloads.tsx

src/features/projectsV2/ProjectDetails/components/microComponents/SingleContactDetail.tsx

mohitb35

@sunilsabatp Please go through my feedback.

…m/Plant-for-the-Planet-org/planet-webapp into projects-redesign/project-details

mariahosfeld · 2024-09-18T11:40:02Z

Please make sure that all datapoint available via the API response are shown in the project details. For a conservation project several are missing.

mariahosfeld · 2024-09-18T11:41:25Z

For Site Ownership it needs to be ensured that we have an automatic break point if the space runs out, currently it is just cut off

mohitb35 · 2024-09-19T09:51:24Z

src/features/projectsV2/ProjectDetails/ProjectDetails.module.scss

+.projectInfoSection {
+  padding: 15px;
+  background: rgba(255, 255, 255, 1);
+  border-radius: 16px;
+  margin-top: 20px;
+  display: flex;
+  flex-direction: column;
+  grid-area: 15px;
+  gap: 15px;
+  box-shadow: 0px 0px 10px 0px rgba(0, 0, 0, 0.1);
+  @include xsPhoneView {
+    box-shadow: none;
+    margin-left: 0px;
+    padding: 15px 30px;
+  }
+}


Move the projectInfoSection styles to ProjectInfo.module.scss - that makes more sense in terms of heirarchy, as ProjectInfoSection lies within the /components folder which uses styles from /styles.

mohitb35 · 2024-09-19T09:53:07Z

src/features/projectsV2/ProjectDetails/index.tsx

+      />
+    </div>
+  ) : (
+    <Skeleton className={styles.projectInfoSkeleton} />


Since we have a ProjectInfoSection component, the projectInfoSkeleton class could be renamed to projectDetailsSkeleton as that is what it appears as a placeholder for

mohitb35 · 2024-09-19T10:06:41Z

src/features/projectsV2/ProjectListControls/styles/ProjectListControls.module.scss

+.projectListControlsMobile {
+  height: 26px;
+  gap: 10px;
+}


Why are we giving a height of 26px here, when the contents within are 28px?

mohitb35 · 2024-09-19T10:09:13Z

src/features/projectsV2/ProjectListControls/styles/ProjectListControls.module.scss

+.marginTop10 {
+  margin-top: 10px;
+}
+
+.marginTop20 {
+  margin-top: 20px;
 }


Still not sure why we need 2 different margins.

Also, while using utility classes is fine, using a mixture of utility classes and other classes can cause confusion. In this scenario, I feel it would be better to use a specific class for impersonation mode.

mohitb35 · 2024-09-19T10:21:56Z

src/features/projectsV2/ProjectDetails/components/ProjectDownloads.tsx

+  const financialAndCertificationData = [
+    {


Let's rename financialAndCertificationData --> downloadsRenderConfig.

It does not represent simple data, but a configuration of what should render and when, and we can also add another item (e.g. progressReports) without having to rename everything to make sense.

mohitb35 · 2024-09-19T10:52:22Z

src/features/projectsV2/ProjectsContext.tsx

+  const [singleProject, setSingleProject] = useState<ProjectExtend | null>(
+    null
+  );


Update the ProjectExtend type to ExtendedProject here as well.

mohitb35 · 2024-09-19T11:01:09Z

src/features/projectsV2/ProjectSnippet/microComponents/ImageSection.tsx

+  const handleBackButton = useCallback((e: MouseEvent) => {
+    e.stopPropagation();
+    if (window.history.length > 0) {
+      window.history.back();
+    } else {
+      window.location.href = '/';
+    }
+  }, []);


The back button logic does not seem right, perhaps this can be taken up in a separate PR though.

mohitb35 · 2024-09-19T12:30:02Z

src/features/projectsV2/ProjectDetails/components/ProjectInfoSection.tsx

+    return Boolean(
+      (isTreeProject && metadata.yearAbandoned) ||
+        (isTreeProject && metadata.firstTreePlanted) ||
+        (isTreeProject && metadata.plantingDensity) ||
+        (isTreeProject && metadata.maxPlantingDensity) ||
+        (isTreeProject &&
+          metadata.plantingSeasons &&
+          metadata.plantingSeasons.length > 0) ||
+        (isConservationProject &&
+          metadata.activitySeasons &&
+          metadata.activitySeasons.length > 0)
+    );


Can this be more readable, with less duplication?

mohitb35 · 2024-09-19T12:30:36Z

src/features/projectsV2/ProjectDetails/components/ProjectInfoSection.tsx

+  const shouldRenderAdditionalInfo = useMemo(() => {
+    const {
+      mainChallenge,
+      siteOwnerName,
+      longTermPlan,
+      acquisitionYear,
+      motivation,
+      mainInterventions,
+    } = metadata;
+    return Boolean(
+      mainChallenge ||
+        siteOwnerName ||
+        (isTreeProject &&
+          metadata.siteOwnerType &&
+          metadata.siteOwnerType?.length > 0) ||
+        (isConservationProject &&
+          metadata.landOwnershipType &&
+          metadata.landOwnershipType?.length > 0) ||
+        (isTreeProject && metadata.degradationCause) ||
+        longTermPlan ||
+        acquisitionYear ||
+        motivation ||
+        (mainInterventions && mainInterventions?.length > 0)
+    );
+  }, [metadata]);


Can this be more readable?

mohitb35 · 2024-09-20T06:30:11Z

src/features/projectsV2/ProjectDetails/components/ProjectInfoSection.tsx

+  } = project;
+  const isTreeProject = purpose === 'trees';
+  const isConservationProject = purpose === 'conservation';
+  const isRestorationProject = purpose === 'trees' && unitType === 'm2';


The isRestorationProject condition does not depend on unitType

mohitb35

@sunilsabatp Please go through all open comments, including the ones from earlier

sunilsabatp added 4 commits August 13, 2024 14:52

feat: create folder for project detail

9464143

fix: minor change in styling

43df3d4

feat: avail back button on the project snippet

9b6ddb2

feat: add about us component to project detail page

cd2c460

sunilsabatp marked this pull request as draft August 18, 2024 12:42

fix: correct the import path

595f027

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup August 18, 2024 12:53 View deployment

sunilsabatp added 5 commits August 19, 2024 11:12

feat: integrate keyInfo and additional project info component

c420699

feat: integrate video and image slider component

196daa5

refactor: move the contact detail component to projectDetail folder

1530c86

refactor: merge base branch,resolve merge conflicts

01325c5

integrate the project download component, resolve type issues

b1d74a0

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup August 23, 2024 10:56 View deployment

sunilsabatp added 2 commits August 25, 2024 12:02

refactor: video player component

f611a3e

feat: integarate dive into map component to the project details page

770b458

mariahosfeld added the PR: draft label Aug 26, 2024

sunilsabatp added 2 commits August 26, 2024 15:35

refactor: refactor additionalInfo component, reolve type issues

40979cb

fix: manage the width

32835f7

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup August 26, 2024 10:49 View deployment

refactor: remove unwanted code

1a929a2

sunilsabatp requested a review from mariahosfeld August 26, 2024 12:23

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup August 26, 2024 12:30 View deployment

mariahosfeld reviewed Aug 26, 2024

View reviewed changes

feat: handle layout for impersonation mode and embed mode

4138af5

sunilsabatp marked this pull request as ready for review August 27, 2024 05:30

sunilsabatp added PR: unreviewed and removed PR: draft labels Aug 27, 2024

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup September 12, 2024 04:31 View deployment

fix: update incorrect import path for IconProps

f4b590c

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup September 12, 2024 09:18 View deployment

mariahosfeld added projects redesign labels Sep 12, 2024

mohitb35 reviewed Sep 14, 2024

View reviewed changes

mohitb35 requested changes Sep 14, 2024

View reviewed changes

sunilsabatp added 3 commits September 16, 2024 12:59

fix: address feedbacks

69b44dc

Merge branch 'projects-redesign/project-details' of https://github.co…

5323c2f

…m/Plant-for-the-Planet-org/planet-webapp into projects-redesign/project-details

merge: merge base branch, resolve conflicts

bb438af

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup September 16, 2024 09:59 View deployment

address feedbacks

8cccdc9

sunilsabatp requested a review from mohitb35 September 18, 2024 09:56

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup September 18, 2024 10:01 View deployment

minor ui adjustment

c8cb6f8

vercel bot deployed to Preview – planet-webapp-multi-tenancy-setup September 18, 2024 10:17 View deployment

mohitb35 reviewed Sep 19, 2024

View reviewed changes

mohitb35 reviewed Sep 20, 2024

View reviewed changes

mohitb35 requested changes Sep 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Projects redesign/project details #2183

Projects redesign/project details #2183

sunilsabatp commented Aug 18, 2024 •

edited by mohitb35

Loading

vercel bot commented Aug 18, 2024 •

edited

Loading

coderabbitai bot commented Aug 18, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mariahosfeld commented Aug 26, 2024

mariahosfeld left a comment

mohitb35 commented Sep 14, 2024 •

edited

Loading

mohitb35 left a comment

mohitb35 left a comment

mariahosfeld commented Sep 18, 2024

mariahosfeld commented Sep 18, 2024

mohitb35 Sep 19, 2024 •

edited

Loading

mohitb35 Sep 19, 2024

mohitb35 Sep 19, 2024

mohitb35 Sep 19, 2024

mohitb35 Sep 19, 2024 •

edited

Loading

mohitb35 Sep 19, 2024 •

edited

Loading

mohitb35 Sep 19, 2024

mohitb35 Sep 19, 2024

mohitb35 Sep 19, 2024

mohitb35 Sep 20, 2024 •

edited

Loading

mohitb35 left a comment

Projects redesign/project details #2183

Are you sure you want to change the base?

Projects redesign/project details #2183

Conversation

sunilsabatp commented Aug 18, 2024 • edited by mohitb35 Loading

vercel bot commented Aug 18, 2024 • edited Loading

coderabbitai bot commented Aug 18, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mariahosfeld commented Aug 26, 2024

mariahosfeld left a comment

Choose a reason for hiding this comment

mohitb35 commented Sep 14, 2024 • edited Loading

mohitb35 left a comment

Choose a reason for hiding this comment

mohitb35 left a comment

Choose a reason for hiding this comment

mariahosfeld commented Sep 18, 2024

mariahosfeld commented Sep 18, 2024

mohitb35 Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024 • edited Loading

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024

Choose a reason for hiding this comment

mohitb35 Sep 19, 2024

Choose a reason for hiding this comment

mohitb35 Sep 20, 2024 • edited Loading

Choose a reason for hiding this comment

mohitb35 left a comment

Choose a reason for hiding this comment

sunilsabatp commented Aug 18, 2024 •

edited by mohitb35

Loading

vercel bot commented Aug 18, 2024 •

edited

Loading

coderabbitai bot commented Aug 18, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

mohitb35 commented Sep 14, 2024 •

edited

Loading

mohitb35 Sep 19, 2024 •

edited

Loading

mohitb35 Sep 19, 2024 •

edited

Loading

mohitb35 Sep 19, 2024 •

edited

Loading

mohitb35 Sep 20, 2024 •

edited

Loading