Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design graph component (CO2 Captured and Canopy Cover) #1984

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

Design graph component (CO2 Captured and Canopy Cover) #1984

wants to merge 30 commits into from
+369 −2

Conversation

prachigarg19
Copy link
Collaborator

@prachigarg19 prachigarg19 commented Feb 21, 2024 •
edited by sunilsabatp
Loading

Component: Carbon Capture
image
Canopy cover
image

Design changes:

  1. The month does not need to be displayed according to current google earth engine response.
  2. The fixed annotation line will now be solid and green while the line that appears on hovering will be dotted
  • Design approved
    Left:
  • Api integration

@vercel Vercel
Copy link

vercel bot commented Feb 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
planet-webapp-multi-tenancy-setup ✅ Ready (Inspect) Visit Preview Jul 12, 2024 10:52am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
planet-webapp ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 10:52am
planet-webapp-temp ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2024 10:52am

@sunilsabatp
Copy link
Contributor

image

can you make the marked portion lighter instead of bold ?

@mohitb35 mohitb35 force-pushed the feature/redesign-explore-btn branch from c7d4a2b to 9d0b734 Compare March 21, 2024 13:26
@mohitb35 mohitb35 force-pushed the feature/redesign-explore-btn branch 3 times, most recently from f54228e to 9ea7417 Compare April 11, 2024 12:00
@mohitb35 mohitb35 added the blocked Should not be merged label Apr 17, 2024
mariahosfeld
mariahosfeld previously requested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@mariahosfeld mariahosfeld left a comment •
edited by sunilsabatp
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Per Figma design we do not have yearly steps, but rather monthly. Will depend on final integration, but should be considered for implementation
    image
  • Check design of vertical line that marks project onset: Per figma design it is not solid
    image

@mariahosfeld mariahosfeld dismissed their stale review July 12, 2024 09:38

Dismissed due to remarks concerning changes in design that were approved.

Base automatically changed from feature/redesign-explore-btn to develop July 18, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilsabatp sunilsabatp sunilsabatp approved these changes

@gangakhushlani gangakhushlani Awaiting requested review from gangakhushlani

@mohitb35 mohitb35 Awaiting requested review from mohitb35

@mariahosfeld mariahosfeld Awaiting requested review from mariahosfeld

Assignees
No one assigned
Labels
blocked Should not be merged projects redesign
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prachigarg19 @sunilsabatp @mariahosfeld @mohitb35