Make qml.Qubitization QJIT compatible
#6305
Open
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into qjit-qubitization
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6305 +/- ##
=======================================
Coverage 99.70% 99.70%
=======================================
Files 444 444
Lines 42223 42224 +1
=======================================
+ Hits 42100 42101 +1
Misses 123 123 ☔ View full report in Codecov by Sentry. |
| decomp_ops.append(qml.Reflection(qml.Identity(control))) | ||
| # QJIT is not compatible with qml.Identity(control), so we build the | ||
| # identity as a tensor product instead | ||
| identity = qml.prod(*[qml.Identity(wire) for wire in control]) |
There was a problem hiding this comment.
Do we need to do this always or only when used in a QJIT setting?
There was a problem hiding this comment.
It's only needed for QJIT. Doing something like qml.Identity(list_of_wires) is not supported, so the identity operator needs to be built another way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catalyst does not support passing a list of wires into the identity operator, so the following code causes a segmentation fault
qml.Identity([0, 1])To make this template QJIT compatible we need to build the Identity operator as a tensor product of single wire Identity operators instead of passing in a list of wires. This PR addresses [sc-74444].