-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove n_procs for nodes that do not use multiple cores #1256
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
==========================================
- Coverage 84.10% 78.26% -5.84%
==========================================
Files 59 59
Lines 7197 7219 +22
Branches 1065 1066 +1
==========================================
- Hits 6053 5650 -403
- Misses 880 1296 +416
- Partials 264 273 +9 ☔ View full report in Codecov by Sentry. |
The integration tests don't seem to contribute to coverage now that we're using the MultiProc plugin, but I think the speed-up is worth the drop in coverage, so I'm going to merge this. |
Closes none, but addresses an issue identified by @mattcieslak.
Changes proposed in this pull request
n_procs=omp_nthreads
.omp_nthreads=*
from any nodes using that. Pretty sure it doesn't do anything.