Problem: cosmos-sdk 0.46 is not used #433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update ibc-go to v4
yihuang
commented
Jul 14, 2022
| let fee_amount = Coin { | ||
| denom: gas_price.1.clone(), | ||
| amount: 0u32.into(), | ||
| amount: fee_amount.into(), |
There was a problem hiding this comment.
cosmos-sdk 0.46 reject 0 gas tx.
There was a problem hiding this comment.
reverted the change, will be fixed at cosmos-sdk side: cosmos/cosmos-sdk#12590
This reverts commit 5b05c96.
|
I know this is a draft PR, but just commenting: ibc-go 4 is still in alpha and 0.46 was just released. We'll upgrade to ibc-go 3 and 0.45.6 in the next release and wait on 0.46 a bit I imagine. |
|
Closing this as we are managing the SDK update process -- the next version will have us on 0.45.13 and we will proceed to 0.46 at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.