fix compatibility with php-cs-fixer 3.59.3 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorismak look really good, I'll check the CI problem tomorrow and release it 👍 Thanks a lot! |
PedroTroller
added a commit
that referenced
this pull request
Aug 2, 2024
* refactor: apply new coding standards * fix compatibility with 3.59.3 * fix compatibility with 3.59.3 (#210) Co-authored-by: Joris Mak <j.mak@nobears.nl> * refactor: apply new coding standards --------- Co-authored-by: Joris Mak <j.mak@nobears.nl> Co-authored-by: Joris Mak <47725838+jorismak@users.noreply.github.com>
This was referenced Aug 2, 2024
Closed
PedroTroller
added a commit
that referenced
this pull request
Aug 2, 2024
* refactor: apply new coding standards * fix compatibility with 3.59.3 * fix compatibility with 3.59.3 (#210) Co-authored-by: Joris Mak <j.mak@nobears.nl> * refactor: apply new coding standards --------- Co-authored-by: Joris Mak <j.mak@nobears.nl> Co-authored-by: Joris Mak <47725838+jorismak@users.noreply.github.com>
|
🎉 This PR is included in version 2.33.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-cs-fixer seems to have changed a bit in their configuration approach between 3.59.2 and 3.59.3.
I don't know if the BC break was meant to happen, or if the fixers in this package are just old and were still using deprecated ways.
Anyway, this seems to fix it.