Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for new check errors in R >= 4.4.0 (models edition) #3383

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

fixes for new check errors in R >= 4.4.0 (models edition) #3383

wants to merge 23 commits into from

Conversation

infotroph
Copy link
Member

@infotroph infotroph commented Sep 17, 2024 •
edited
Loading

Description

Completes the trawl through check output I started in #3346 and #3350 -- see there for more context.

As before, this PR touches a lot of files, but most changes are pretty simple. Review protip: If reviewing in the browser, use the [ ] Viewed checkboxes to collapse each file when you're confident you don't need to look at it more -> makes it easier to review PRs like this one in multiple sessions if needed.

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph
fixes for new check errors in R >= 4.4.0 (modules edition)
fe5209b
@infotroph
First steps on updating models for R 4.4 check phrasing (incomplete)
56d803d
@infotroph
more cleanup in biocro
80a0c46 
- dockerfile and model_info.json to Rbuildignore
- remove badly outdated vignette
- ignore complaint about license formatting
- lazyData not needed when no data in package
- fix broken crosslink
@infotroph
make clm45 pass checks on R 4.4
b5b47e5
@infotroph
make dalec pass checks on R 4.4
8999162
@infotroph
make dvmdostem pass checks on R 4.4
0e9d7c0
@infotroph
update PEcAn.ED2 to pass checks on R 4.4
7319f24
@infotroph
remove invalid DCF notes resolved by just-merged license change
60428e0
@infotroph
fates: pass checks on R 4.4
879b237
@infotroph
gday: pass checks on R 4.4
169d574
@infotroph
jules: pass checks on R 4.4
7b54cd0
@infotroph
linkage: pass checks on R 4.4 (+deps regenerate)
0e427b0
@infotroph
lpjguess: pass checks on R 4.4
1bb1462
@infotroph
partial check fixes for PEcAn.MAAT on R 4.4
6674c11
@infotroph
MAAT vignette: provide cached format object
fc88b40
@infotroph
maespa: pass checks on R 4.4
966289b
@infotroph
more deps
d0d50b9
@infotroph
preles: pass checks on R 4.4
a370d7a
@infotroph
sibcasa: pass checks on R 4.4
0518273
@infotroph
sipneet: pass checks on R 4.4
2faf628
@infotroph
Copy link
Member Author

Status: Needs #3382 to fix current check failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdietze mdietze mdietze approved these changes

Assignees
No one assigned
Labels
Base Dockerfile Models Modules Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infotroph @mdietze